Backport 89351 to v3.7 branch: Fix operation bounds check for Flash Map API #93503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent possible overflow in is_in_flash_area_bounds while validating offset and length of an operation. Fixes #89349 Signed-off-by: Dominik Ermel <[email protected]> (cherry picked from commit 3d4b427)
|
@de-nordic This should not be fixing a 'Failed to backport' issue, you have to reference the original issue being fixed |
de-nordic
force-pushed
the
backport-89351-to-v3.7-branch
branch
from
566bc34 to
97cf162
Compare
|
Had to drop test scenario, because it uses newer macros not supported in 3.7. |
|
kartben
approved these changes
Jul 23, 2025
henrikbrixandersen
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All functions area using is_in_flash_area_bounds for checking parameters; the function was not immune to integer overflow.
The PR fixes the function and adds test scenario for overflows.
Fixes #89349